Fix on_hover_collector_over not deactivating thrusters - #5
Open
wannerdev wants to merge 1 commit into
Open
Conversation
- Added thruster_query parameter to on_hover_collector_over - Now properly deactivates thrusters when removing NavigationInstruments - Prevents thrusters from staying active on deselected satellites - Fixes mobile input issue where thrusters remained active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where hovering over a satellite to select it would not properly deactivate the thrusters of previously selected satellites, causing them to continue burning fuel and applying thrust.
Changes
thruster_queryparameter toon_hover_collector_overfunctionBug Details
Before: When hovering over a new satellite, the old satellite would lose its NavigationInstruments marker but its thruster would remain active, continuing to burn fuel and apply force.
After: When hovering over a new satellite, the old satellite's thruster is properly deactivated along with removing the NavigationInstruments marker.
Testing
Related Issue
Fixes: Bug - on_hover_collector_over does not remove thruster components (related to mobile input)